Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: @o3r/create should generate end-of-line LF config #2628

Closed
malek-benazzouz opened this issue Dec 18, 2024 · 0 comments · Fixed by #2635
Closed

[Feature]: @o3r/create should generate end-of-line LF config #2628

malek-benazzouz opened this issue Dec 18, 2024 · 0 comments · Fixed by #2635
Assignees
@matthieu-crouzet
Labels
enhancement New feature or request priority:low quick
Milestone
On boarding impro...

Comments

@malek-benazzouz
Copy link

Context

When generating a project using @o3r/create, do we want the generator to automatically add the LF end-of-line config?

Proposal

To handle the LF config, we could:

  1. Add the following line in .editorconfig file: end_of_line = lf.
  2. Generate a .gitattributes file containing at least this line: * text eol=lf.
@malek-benazzouz malek-benazzouz added enhancement New feature or request triage labels Dec 18, 2024
@kpanot kpanot added this to the On boarding improvement milestone Dec 19, 2024
@matthieu-crouzet matthieu-crouzet self-assigned this Dec 19, 2024
matthieu-crouzet added a commit that referenced this issue Dec 19, 2024
@matthieu-crouzet
fix(#2628): generate eol LF config
b4f1a2f
@matthieu-crouzet matthieu-crouzet mentioned this issue Dec 19, 2024
Merged
matthieu-crouzet added a commit that referenced this issue Dec 20, 2024
@matthieu-crouzet
fix(#2628): generate eol LF config
7b41e4e
matthieu-crouzet added a commit that referenced this issue Dec 20, 2024
@matthieu-crouzet
fix(#2628): generate eol LF config
c22bda8
matthieu-crouzet added a commit that referenced this issue Jan 8, 2025
@matthieu-crouzet
fix(#2628): generate eol LF config
419f669
matthieu-crouzet added a commit that referenced this issue Jan 8, 2025
@matthieu-crouzet
fix(#2628): generate eol LF config
1572429
matthieu-crouzet added a commit that referenced this issue Jan 9, 2025
@matthieu-crouzet
fix(#2628): generate eol LF config
a587e79
matthieu-crouzet added a commit that referenced this issue Jan 10, 2025
@matthieu-crouzet
fix(#2628): generate eol LF config
d94be5f
matthieu-crouzet added a commit that referenced this issue Jan 10, 2025
@matthieu-crouzet
fix(#2628): generate eol LF config
4586b03
github-merge-queue bot pushed a commit that referenced this issue Jan 10, 2025
@matthieu-crouzet
fix(#2628): generate eol LF config (#2635)
897af75 
## Proposed change

Generate eol LF config

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

<!-- * 🐛 Fix #issue -->
* 🐛 Fix resolves #2628
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthieu-crouzet matthieu-crouzet

Labels
enhancement New feature or request priority:low quick
Projects
None yet
Milestone
On boarding improvement
Development

Successfully merging a pull request may close this issue.

fix(#2628): generate eol LF config AmadeusITGroup/otter
3 participants
@kpanot @malek-benazzouz @matthieu-crouzet