Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong dependencies added by the library generator #2666

Open
malek-benazzouz opened this issue Jan 6, 2025 · 0 comments
Open

[Bug]: Wrong dependencies added by the library generator #2666

malek-benazzouz opened this issue Jan 6, 2025 · 0 comments
Labels
bug Something isn't working triage

Comments

@malek-benazzouz
Copy link

Package name

core

Package version

11.5.3

Reproduction steps

Create a project with @o3r/create, then generate an app and a lib:

npm create @o3r project
ng g application app
ng g library lib

Current result

The 2 following dependencies were added by the app generator in dependencies section of the root package.json file, but then were also added by the lib generator in devDependencies section. As a result, they are now duplicated, which is not ideal because it could lead to further issues (e.g. version mismatch?):

    "@ngrx/entity": "~18.0.0",
    "@ngrx/store": "~18.0.0"

Also, the following peerDependencies is added in the root package.json file, which is probably a mistake (not sure why a root package.json file would need a peerDeps section):

"peerDependencies": {
    "@ngrx/entity": "~18.0.0",
    "@ngrx/store": "~18.0.0"
  }

Expected result

The lib generator should not add these 2 dependencies if they are already present.
It should also not create a peerDependencies section in the root package.json file.

Additional comments

No response

@malek-benazzouz malek-benazzouz added bug Something isn't working triage labels Jan 6, 2025
@kpanot kpanot added this to the On boarding improvement milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants