Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LINT_BUG]: Error on non-existing box module #108

Open
radbasa opened this issue Jun 7, 2024 · 1 comment
Open

[LINT_BUG]: Error on non-existing box module #108

radbasa opened this issue Jun 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@radbasa
Copy link
Collaborator

radbasa commented Jun 7, 2024

box.linters version

0.9.1

Sample source code to lint

box::use(path/some_module, )

Lint command used

lintr::lint(
  code,
  linters = lintr::linters_with_defaults(defaults = box.linters::rhino_default_linters)
)

Lint result

Error: Linter 'box_unused_attached_mod_linter' failed in xxxxx: unable to load module “path/some_module”; not found in...

Expected result

Should return lint that module does not exist.

@radbasa radbasa changed the title [LINT_BUG]: Error on non existing box module [LINT_BUG]: Error on non-existing box module Jun 7, 2024
@radbasa radbasa added the bug Something isn't working label Jun 7, 2024
@SaintRod
Copy link

I'm receiving this error in version 0.10.5 when the module does exist and there is no error in box::use().

example project structure:

  • root
    • functions
      • foo
        • a.R
      • bar
        • b.R

In file ./functions/foo/a.R

box::use(
  .. / bar / b[some_function]
)

There is no error in importing the module when the box code is executed, however, linting file a.R fails with "... unable to load module ..."

box::use(
  box.linters[box_default_linters],
  here[here],
  lintr[lint, lint_dir],
)
lint(
  filename = here("functions", "foo", "a.R"),
  linters = box_default_linters$box_mod_fun_exists_linter
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants