Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Close Logic. #12

Open
ezazpi opened this issue Feb 21, 2022 · 1 comment
Open

Port Close Logic. #12

ezazpi opened this issue Feb 21, 2022 · 1 comment

Comments

@ezazpi
Copy link

ezazpi commented Feb 21, 2022

In the source, I see you keep a reference to the writableStreamClosed promise. However, you don't await this promise nor is there any logic to close the writer, reader, and port. I also saw the reader.releaseLock line commented (I don't recall if there was a writer.releaseLock). Maybe there can be a Close button to exercise this logic, which would allow the user to reuse the serial port without necessarily having to close the browser tab?

@mmiscool
Copy link
Member

Hitting the refresh button when you want to connect to a new device is a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants