Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Image Builder New API Version Request - 2023-07-01 #27946

Closed
1 task done
zdelacerda-microsoft opened this issue Nov 29, 2023 · 9 comments · Fixed by #28106
Closed
1 task done

Azure Image Builder New API Version Request - 2023-07-01 #27946

zdelacerda-microsoft opened this issue Nov 29, 2023 · 9 comments · Fixed by #28106
Assignees
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot feature-request

Comments

@zdelacerda-microsoft
Copy link
Member

zdelacerda-microsoft commented Nov 29, 2023

Preconditions

  • No need to upgrade Python SDK or the Python SDK is ready.

Related command

az image builder error-handler add
az image builder error-hander remove
az image builder error-handler show

Resource Provider

Microsoft.VirtualMachineImages (Azure VM Image Builder)

Description of Feature or Work Requested

Add new top level errorHandling property group.

az image builder error-handler add [--on-customizer-error {cleanup, abort}, --on-vaidation-error]

Customers may specify the error handling behavior for an error that occurs during customize: either clean up or abort.
-Clean up is the existing and default behavior which cleans up the customizing VM.
-Abort will preserve the customizing VM to allow the customer to investigate the error that occurred during customizing. The customer is responsible for manually cleaning up the VM and related resources when abort is specified.

az image builder error-handler remove (no input)
az image builder error-handler show (output: --on-customizer-error and --on-validation-error)

Minimum API Version Required

2023-07-01

Swagger PR link / SDK link

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2022-02-14 and stable/2023-07-01 by zdelacerda-microsoft · Pull Request #26309 · Azure/azure-rest-api-specs (github.com)

[API 2023-07-01 Update] Fixing distribute in ImageTemplateUpdateParameters by zdelacerda-microsoft · Pull Request #26487 · Azure/azure-rest-api-specs (github.com)

Request Example

onCustomizerError set to cleanup

onCustomizerError set to abort and onValidationError set to cleanup

Target Date

2023-12-31

PM Contact

kofiforson

Engineer Contact

zdelacerda

Additional context

No response

@microsoft-github-policy-service microsoft-github-policy-service bot added the Compute az vm/vmss/image/disk/snapshot label Nov 29, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 29, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 29, 2023

Thank you for opening this issue, we will look into it.

@yonzhan yonzhan added this to the Backlog milestone Nov 29, 2023
@yonzhan yonzhan removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Nov 29, 2023
@uiri
Copy link

uiri commented Nov 30, 2023

I think both --on-customizer-error and --on-validation-error should be valid flags for add and should be returned values for show.

@yanzhudd
Copy link
Contributor

yanzhudd commented Dec 3, 2023

Target Date
2023-12-31

Hi @zdelacerda-microsoft,
please note that CLI the next release date is 2024-01-02. Is it acceptable for you?

@zdelacerda-microsoft
Copy link
Member Author

Target Date
2023-12-31

Hi @zdelacerda-microsoft, please note that CLI the next release date is 2024-01-02. Is it acceptable for you?

That's acceptable. Thank you

@yanzhudd
Copy link
Contributor

yanzhudd commented Dec 8, 2023

Hi @zdelacerda-microsoft,
it seems that this new added property is not in the current SDK package. Please note that CLI uses Azure Python SDK to interact with backend side, so only when the SDK is ready can we develop this feature.
Please contact SDK team to release a new version firstly. Since SDK team follow monthly release cycle, please follow https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/release-request/rules-for-release-request.md to raise release request issue to catch up release train of this month. Thanks!

@uiri
Copy link

uiri commented Dec 12, 2023

The latest public Azure Python SDK release appears to be more than 6 months old. It doesn't make any sense to me that there has not been any Azure Python SDK release since April.

@yanzhudd
Copy link
Contributor

Hi @zdelacerda-microsoft, it seems that this new added property is not in the current SDK package. Please note that CLI uses Azure Python SDK to interact with backend side, so only when the SDK is ready can we develop this feature. Please contact SDK team to release a new version firstly. Since SDK team follow monthly release cycle, please follow https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/release-request/rules-for-release-request.md to raise release request issue to catch up release train of this month. Thanks!

please release the Azure Python SDK before 12-18 so that we have time to develop and test, otherwise this feature has to be postponed to next sprint (release date is 2024-02-06).

@zdelacerda-microsoft
Copy link
Member Author

Hi @yanzhudd, python SDK is now updated. Is this still on track for 2024-02-06?

@yanzhudd
Copy link
Contributor

Hi @yanzhudd, python SDK is now updated. Is this still on track for 2024-02-06?

Yeah, it is still on track for 02-06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot feature-request
Projects
None yet
5 participants