Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Az sig update SoftDeletePolicy keep to be null if user does not specify #27992

Closed
kangsun-ctrl opened this issue Dec 8, 2023 · 1 comment · Fixed by #28059
Closed

Az sig update SoftDeletePolicy keep to be null if user does not specify #27992

kangsun-ctrl opened this issue Dec 8, 2023 · 1 comment · Fixed by #28059
Assignees
@zhoxing-ms @yanzhudd
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone
Backlog

Comments

@kangsun-ctrl
Copy link
Contributor

Related command
az sig update

Is your feature request related to a problem? Please describe.
Yes.

Current scenario: user does 'az sig update' without '--soft-delete-policy', CLI will still pass in SoftDeletePolicy to the backend if the Get result has SoftDeletePolicy.

Ask: When user does 'az sig update' without '--soft-delete-policy', CLI do not pass in SoftDeletePolicy to the backend(set it as null). If user specify '--soft-delete-policy' in CLI, then CLI pass in whatever user passed to backend.

Otherwise we would get icm like https://portal.microsofticm.com/imp/v3/incidents/details/446631906/home

Describe the solution you'd like
Described above.

Describe alternatives you've considered
An alternative is that we remove all DM of softDeletePolicy, but that could be a huge effort.
@microsoft-github-policy-service microsoft-github-policy-service bot added the Compute az vm/vmss/image/disk/snapshot label Dec 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 8, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 8, 2023

Thank you for opening this issue, we will look into it.

@yonzhan yonzhan added this to the Backlog milestone Dec 9, 2023
@ReaNAiveD ReaNAiveD mentioned this issue Dec 19, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhoxing-ms zhoxing-ms

@yanzhudd yanzhudd

Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

{Compute} az sig update: Set SoftDeletePolicy to null if no --soft-delete-policy ReaNAiveD/azure-cli
4 participants
@zhoxing-ms @yonzhan @kangsun-ctrl @yanzhudd