Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making RBF available in swaps for increasing fees of pending transactions in internal wallet #376

Open
massmux opened this issue Jan 20, 2025 · 2 comments
Assignees

Comments

@massmux
Copy link

massmux commented Jan 20, 2025

It would be nice that when sending a swap originating from internal wallet (Bitcoin onchain) we would raise fees via RBF. Actually we see that such transactions are sent with RBF=False. So if should be sent as RBF=True and there should be introduced a command fo raise the fees of a pending transaction belonging to a swap.

@jackstar12
Copy link
Member

Currently, RBF is disabled explicitly so we can do 0-conf lockup transactions on liquid, but we can stop doing that for mainchain.

Relevant: https://gdk.readthedocs.io/en/latest/gdk-create-tx.html#fee-bump

@michael1011
Copy link
Member

Yeah, let's enable RBF for mainchain and implement a wallet bumpfee command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants