Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended minimum PHP Version Revision to 5.4.0 #32

Open
cpiggott opened this issue Feb 27, 2019 · 0 comments
Open

Recommended minimum PHP Version Revision to 5.4.0 #32

cpiggott opened this issue Feb 27, 2019 · 0 comments

Comments

@cpiggott
Copy link
Contributor

cpiggott commented Feb 27, 2019

I've been looking through the DwollaSwagger API and noticed that there are inconsistencies within the minimum version for PHP and code syntax that is used.

Specifically a few issues I've found are:

Short Array Syntax : This can be seen throughout the application, creating arrays using short syntax example:
[1,2,3,4]
This was not supported until version 5.4.0 of PHP, but is seen throughout the application. PHP 5.4.0 New Features, Short Array Syntax

Function Array Dereferencing : Dereferencing a function array return was not supported until 5.4.0 either but can be seen at in ApiClient:L307 and in other places in the app.
Ex:

$data = !isset(self::http_parse_headers($http_header)["Location"])

PHP 5.4.0 New Features, Function Array Dereferencing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant