Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make project link nodes application aware #30

Open
Steve-Mcl opened this issue Jun 5, 2023 · 5 comments
Open

Make project link nodes application aware #30

Steve-Mcl opened this issue Jun 5, 2023 · 5 comments
Assignees
Labels
customer request requested by customer feature-request New feature or request that needs to be turned into Epic/Story details size:M - 3 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Milestone

Comments

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Jun 5, 2023

Description

Currently, the Project Link Nodes access the depreciated teams/<team>/projects endpoint for a list of all instances.

A future update to the project should use the replacement endpoints to provide a hierarchal view to permit targeting by application->instance

Requested By

Epic/Story

No response

@Steve-Mcl Steve-Mcl added size:M - 3 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story. labels Jun 5, 2023
@lgrkvst
Copy link

lgrkvst commented Sep 6, 2023

Nice to have: include applicationId in msg.projectLink for those cases where responses are application-specific.

@Steve-Mcl
Copy link
Contributor Author

Not explicitly called out so making an additional comment:
Instance owned devices can be targeted directly by project-link-out and project-link-call.

As part of making the project nodes play nicely when used with application-bound devices will be the ability to target them like you can an instance-assigned device. That would permit users to use project-out and project-link-call nodes from instance -> app-device (and vice versa).

@joepavitt joepavitt added this to the 2.10 milestone Sep 30, 2024
@joepavitt joepavitt moved this to Todo in 🛠 Development Sep 30, 2024
@joepavitt joepavitt added feature-request New feature or request that needs to be turned into Epic/Story details customer request requested by customer labels Sep 30, 2024
@Steve-Mcl Steve-Mcl self-assigned this Oct 1, 2024
@Steve-Mcl Steve-Mcl moved this from Todo to In Design in 🛠 Development Oct 1, 2024
@Steve-Mcl
Copy link
Contributor Author

following a discussion in engineering meeting today, I am moving this back into TODO.

Any Other Business:

  • Steve: Project nodes
    • project-nodes have been around since before the concept of applications and therefore permit instances from one application to communicate with instances in any application belonging to the team. As I see it, have 3 immediate/obvious choices to support application awareness.
        1. Simply provide the application name as a means of filtering / organising the choice of instance (this means the project nodes retain the same functionality for cross-application communication / backwards compatibility)
        1. Depreciate the project nodes in favour of newer set of "link-nodes" (name TBD) that are strictly scoped to an application (see Rebranding "Project Nodes" #94)
        1. Introduce cross-application scoping as an option in the platform (defaulted to permit it for backwards compatibility) that instructs the core + nodes of application choice
    • Joe: My vote is 1 or 2
      • Feel like we need Nick’s voice on this
      • 1 seems like the smallest iteration, but we’ve been asked by ZJ to rebrand PN for a long time, and this feels like a good opp
        • Steve: rebranding (as a facelift) is not insurmountable but a full rebranding (i.e. rename/replace package) might leave us with a legacy package to support. We could re-use the internal node names so that the new package is an in-place replacement, however there is still the question of application scope.
  • Joe: How many people are using project nodes?
    • Steve: I know of xxxx and yyyy off the top of my head.
      • FOLLOW-UP: Will see if I can glean anything from logs.
    • Steve: Following discussion with the team, the agreed direction at this time is to update the issue with our discussion and park it until such a time we can discuss with Nick.

FOA @knolleary

@Steve-Mcl Steve-Mcl moved this from In Design to Todo in 🛠 Development Oct 1, 2024
@Steve-Mcl
Copy link
Contributor Author

  • FOLLOW-UP: Will see if I can glean anything from logs.

With assistance from @ppawlowski a scan and summation of the logs seems to indicate over the last 1 week, there were 65 unique client IDs (that match the project-nodes signature) suggesting that option 2 may not be the huge battle we expect.

Of course, 1 week is a small sample but it can be used as an indicator in decision making for now.

@knolleary knolleary modified the milestones: 2.10, 2.11 Oct 25, 2024
@joepavitt joepavitt modified the milestones: 2.11, 2.12 Nov 29, 2024
@Elevate-IT
Copy link

We had a call with Ben and Michael today.

Maybe it's helpful to further clarify our use case:
Our goal is to be able to send HTTP requests to a cloud-hosted instance(relay) secured with a token.
This "relay" instance will then forward the message to the configured device agent via the project nodes.
This approach eliminates the need to open an HTTP port within the client's network.

Flow:
External System (HTTP) <-> Cloud "Relay" Instance <-> Device Agent Instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer request requested by customer feature-request New feature or request that needs to be turned into Epic/Story details size:M - 3 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
Status: Todo
Development

No branches or pull requests

5 participants