Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrained classification issue #8

Open
Alea4jacta6est opened this issue Jan 1, 2024 · 3 comments
Open

Constrained classification issue #8

Alea4jacta6est opened this issue Jan 1, 2024 · 3 comments

Comments

@Alea4jacta6est
Copy link

Hi, I try to get predictions for my atlas using your notebook:

target_celltypes = ["B cell", "CD4 T cell", "DN T cell", "MAIT cell", "Myeloid cell", "NK cell", "Progenitor cell", "CD8 T cell", "gd T cell"]
ca.safelist_celltypes(target_celltypes)

And this annotation works for more than 48 hours:
adams = ca.annotate_dataset(adams, skip_preprocessing=True)

Is it normal? May the issue be related to the way I write down the cell types? Do you have an approach to estimate the time of running for the constrained classification?

@tony-kuo
Copy link
Collaborator

tony-kuo commented Jan 3, 2024

Safelisting will be slower due to circumventing the indexing of the hnswlib kNN implementation. With too few valid cell types, it will perform basically an exhaustive search. It will perform faster if you expand the list of celltypes, or even without restrictions first to see the unconstrained results before any filtering.

We are looking at alternative kNN implementations that can perhaps perfom better in this scenario.

@Alea4jacta6est
Copy link
Author

Thanks for the answer! Can the problem also be only with naming in the list? I actually made a subset of cell names from constrained predictions and it worked much faster (2 hours instead of 2 days).

@DarioS
Copy link

DarioS commented Nov 22, 2024

I have only cancer patient-derived fibroblast cell cultures. Fast constrained classification would be desirable for one cell type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants