no-unnecessary-push

[Glavin001]

myMethod(myInput) {
    const promises = [];
    promises.push(this.aMethod());
    promises.push(this.anotherMethod());
    return Promise.all(promises);
}

should be

myMethod(myInput) {
    return Promise.all([
      this.aMethod(),
      this.anotherMethod(),
    ]);
}

---

For version 1, .push inside of if statement should be ignored and pass for the array:

myMethod(myInput) {
    const promises = [];
    promises.push(this.aMethod());
    if (myInput.someProp) {
      promises.push(this.anotherMethod());
    }
    return Promise.all(promises);
}