Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest folder missing in click-to-deploy/k8s/prometheus #2382

Open
1 of 3 tasks
s-shoukath opened this issue Jul 24, 2023 · 1 comment
Open
1 of 3 tasks

Manifest folder missing in click-to-deploy/k8s/prometheus #2382

s-shoukath opened this issue Jul 24, 2023 · 1 comment
Labels
kind/k8s Related to the Kubernetes application needs-triage This wasn't investigate by the repo's owners yet

Comments

@s-shoukath
Copy link

s-shoukath commented Jul 24, 2023

Category:

Kubernetes apps

Type:

  • Bug
  • Feature Request
  • Process

Bug

Cloned click-to-deploy repo, but the manifest folder which is supposed to contain manifest files is missing in the repo. Deployment of prometheus will not work without this folder. Here is an output with files available when we clone the repo

shoukathali@shoukathali:/test$ git clone --recursive https://github.com/GoogleCloudPlatform/click-to-deploy.git
Cloning into 'click-to-deploy'...
remote: Enumerating objects: 33599, done.
remote: Counting objects: 100% (1237/1237), done.
remote: Compressing objects: 100% (706/706), done.
remote: Total 33599 (delta 505), reused 1027 (delta 357), pack-reused 32362
Receiving objects: 100% (33599/33599), 33.79 MiB | 16.66 MiB/s, done.
Resolving deltas: 100% (19509/19509), done.
shoukathali@shoukathali:
/test$ cd click-to-deploy/k8s/prometheus
shoukathali@shoukathali:/test/click-to-deploy/k8s/prometheus$ ls
apptest chart deployer Makefile README.md resources schema.yaml
shoukathali@shoukathali:
/test/click-to-deploy/k8s/prometheus$

Here is the command in the steps that mentions about folder manifest

awk 'FNR==1 {print "---"}{print}' manifest/*
| envsubst '$APP_INSTANCE_NAME $NAMESPACE $STORAGE_CLASS $IMAGE_PROMETHEUS $IMAGE_ALERTMANAGER $IMAGE_KUBE_STATE_METRICS $IMAGE_NODE_EXPORTER $NAMESPACE $PROMETHEUS_REPLICAS $PROMETHEUS_REPLICAS $PROMETHEUS_SERVICE_ACCOUNT $KUBE_STATE_METRICS_SERVICE_ACCOUNT $ALERTMANAGER_SERVICE_ACCOUNT $NODE_EXPORTER_SERVICE_ACCOUNT' \

"${APP_INSTANCE_NAME}_manifest.yaml"

@s-shoukath s-shoukath added kind/k8s Related to the Kubernetes application needs-triage This wasn't investigate by the repo's owners yet labels Jul 24, 2023
@cpopescu
Copy link

cpopescu commented Jan 7, 2025

This commit changed the structure of prometheus dir but did not update the README - looks like the configs are in chart/prometheus/templates/ and look like jsonnet
7649ca8#diff-dbd6ecb59d54f2827446fbcb648b7884f962c2702d3486ff5d8bdcdba45a4b18R3

Can somebody pls update the README in that dir on how to generate it ? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/k8s Related to the Kubernetes application needs-triage This wasn't investigate by the repo's owners yet
Projects
None yet
Development

No branches or pull requests

2 participants