Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all tabindex usage > 0 #1206

Open
jakejackson1 opened this issue Mar 2, 2021 · 0 comments · May be fixed by #1279
Open

Remove all tabindex usage > 0 #1206

jakejackson1 opened this issue Mar 2, 2021 · 0 comments · May be fixed by #1279
Assignees
Labels
Milestone

Comments

@jakejackson1
Copy link
Member

jakejackson1 commented Mar 2, 2021

Description
tabindex controls the focus order. We should never change the focus order that the browser sets, and only make use of tabindex=-1 or tabindex=0 (or no tabindex at all) to determine if the element should or should not be focusable.

Step To Reproduce
Steps to reproduce the behavior:

  1. Go to Font Manager

Expected behavior
To be able to tab through all the elements correctly without having to have a manual tab index.

Screenshots
Screen Shot 2021-03-03 at 10 45 05 am

@jakejackson1 jakejackson1 added this to the 6.x milestone Apr 22, 2021
@debbieellis7 debbieellis7 linked a pull request Apr 28, 2021 that will close this issue
4 tasks
@debbieellis7 debbieellis7 linked a pull request Apr 28, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants