Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fold_analysis_latest.sif generation scores problem #480

Open
Qrouger opened this issue Jan 20, 2025 · 8 comments
Open

fold_analysis_latest.sif generation scores problem #480

Qrouger opened this issue Jan 20, 2025 · 8 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists
Milestone

Comments

@Qrouger
Copy link
Contributor

Qrouger commented Jan 20, 2025

Hi, the latest version of the Singularity image for generate scores don't calculate pi_score for me.

predictions_with_good_interpae.csv

Image

@DimaMolod
Copy link
Collaborator

yes, this is because we removed ccp4 from the image. Please refer to #472

@DimaMolod DimaMolod added the duplicate This issue or pull request already exists label Jan 20, 2025
@Qrouger Qrouger closed this as completed Jan 20, 2025
@Qrouger
Copy link
Contributor Author

Qrouger commented Jan 23, 2025

I'm sorry but I cannot generate the pi_score by following the image build with ccp4. It's maybe cause by the ccp4 version (v9.0.005) ?

@DimaMolod
Copy link
Collaborator

I am sorry to hear that. Yes, it could be because of incompatible ccp4 version, could you try to downgrade ccp4? Can you also provide log files with exact exceptions? If they are not informative, there is a trick you could try:
run your singularity image interactively with this command:
singularity shell /path/to/container.sif
...and try to run pi score script from within the container using these scripts:
https://github.com/KosinskiLab/AlphaPulldown/blob/main/alphapulldown/analysis_pipeline/run_pi_score.sh
https://github.com/KosinskiLab/AlphaPulldown/blob/main/alphapulldown/analysis_pipeline/run_get_good_pae.sh
the chances are that this way you will be able to get a more comprehensive error message.

@DimaMolod DimaMolod reopened this Jan 24, 2025
@Qrouger
Copy link
Contributor Author

Qrouger commented Jan 27, 2025

Hi, I can't found solution to downgrade ccp4.
I run singularity exec --no-home --bind /data/result_all_vs_all:/mnt ~/Downloads/ccp4-9/fold_analysis_latest_withCCP4.sif run_get_good_pae.sh --output_dir=/mnt --cutoff=10

Log files don't show problems.

log_fold_analysis.txt

I don't know when run_pi_score.py/.sh are used.

@DimaMolod DimaMolod added the bug Something isn't working label Jan 27, 2025
@DimaMolod DimaMolod added this to the Priority1 milestone Jan 27, 2025
@jstigler
Copy link

FWIW, the pi_score calculation script appears commented out in run_and_summarise_pi_score:

 # We decided to remove pi_score from the pipeline
                #result = subprocess.run(command, capture_output=True, text=True)
                #if result.returncode != 0:
                #    return self._handle_pi_score_error(result, command, result.stderr)

I still end up with errors though:

All features could not be calculated successfully for atleast one of the interfaces!\n
Exiting\n
stderr=' SC: mds: too many atoms\n')
Command: ['bash', '-c', 'source activate pi_score && export PYTHONPATH=/software:$PYTHONPATH && python /software/pi_score/run_piscore_wc.py -p /mnt/XXXX_and_YYYY/ranked_0.pdb -o /tmp/tmphidm1__z -s 2']. Error: SC: mds: too many atoms

@jkosinski
Copy link
Collaborator

Yeah, we commented it out as a quick fix after removing CCP4 from the default installation, assuming that pi_score might not be essential. @DimaMolod, maybe we could add a conditional check for CCP4 availability and run it if present?

The "Error: SC: mds: too many atoms" message looks familiar. We encountered it occasionally with large or highly clashing structures. It originates from the SC program in CCP4 and has not been resolved so far. Does the analysis pipeline crash entirely, or does it just skip this model?

@DimaMolod
Copy link
Collaborator

DimaMolod commented Jan 31, 2025

Yeah, we commented it out as a quick fix after removing CCP4 from the default installation, assuming that pi_score might not be essential. @DimaMolod, maybe we could add a conditional check for CCP4 availability and run it if present?

yes, we removed pi_score because it doesn't work with the newer CCP4 version, and AFAIK there is no way to install the older version...the underlying reason is that pi_score is written in python2.7

The "Error: SC: mds: too many atoms" message looks familiar. We encountered it occasionally with large or highly clashing structures. It originates from the SC program in CCP4 and has not been resolved so far. Does the analysis pipeline crash entirely, or does it just skip this model?

I am afraid this error message is generic and can mean a variety of actual problems.
@jkosinski from the feedback I collected so far, this whole approach with re-installing CCP4 locally is very unstable and needs to be revisited ASAP.

@jstigler
Copy link

Does the analysis pipeline crash entirely, or does it just skip this model?
It keeps going with the other models. It just doesn't fill the corresponding entries in the table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants