Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for grouping convolution filters #112

Open
mkaze opened this issue Jun 10, 2021 · 5 comments
Open

[Feature Request] Add support for grouping convolution filters #112

mkaze opened this issue Jun 10, 2021 · 5 comments
Labels
good first issue Good for newcomers research Research or reproducing code from science paper

Comments

@mkaze
Copy link
Contributor

mkaze commented Jun 10, 2021

Currently, the support for grouping convolution filters in convolution layers is missing. For more information, you can read the groups argument description of Conv2D layer in Keras here, or in PyTorch here.

@mkaze
Copy link
Contributor Author

mkaze commented Jun 10, 2021

Though, currently the underlying TF Java API does not support grouped convolutions. Alternatively, this could be implemented by grouping the input channels, applying filters separately and then concatenating the results.

@zaleslaw zaleslaw changed the title Add support for grouping convolution filters [Feature Request] Add support for grouping convolution filters Jun 10, 2021
@zaleslaw zaleslaw added the enhancement New feature or request label Jun 10, 2021
@zaleslaw
Copy link
Collaborator

Agree, that this functionality is missed, the initial idea to make MVP DL framework - to implement building blocks required to make parse and load CV models from the Keras.applications. As I understand, that groups are not used in the SOTA models, but maybe you could share architecture, competition or abstract/paper where it was used. I mean, do we really need this functionality?

@mkaze
Copy link
Contributor Author

mkaze commented Jun 10, 2021

@zaleslaw I think ResNeXt used grouped convolutions; but I agree that it's not a crucial feature to have at this moment, especially for an MVP.

@zaleslaw
Copy link
Collaborator

zaleslaw commented Jun 11, 2021

If it is used in ResNeXt - it could make sense, the problem with ResNeXt is the following: it's not on the official list of pre-trained Keras models yet, but the model is created and the PR is proposed. I subscribed to these issues and PR to wait for the official release of the Resnext model.

But if you are interested in this task, feel free to share ideas and draft here.

@zaleslaw zaleslaw added the research Research or reproducing code from science paper label Jun 11, 2021
@zaleslaw
Copy link
Collaborator

P.S Read the Contributing Guidelines.

@zaleslaw zaleslaw added good second issue Good for advanced contributors and removed enhancement New feature or request labels Aug 3, 2021
@zaleslaw zaleslaw added this to the 0.4 milestone Sep 13, 2021
@zaleslaw zaleslaw modified the milestones: 0.4, 0.5 Dec 15, 2021
@zaleslaw zaleslaw added good first issue Good for newcomers and removed good second issue Good for advanced contributors labels Dec 15, 2021
@ermolenkodev ermolenkodev removed this from the 0.5 milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers research Research or reproducing code from science paper
Projects
None yet
Development

No branches or pull requests

3 participants