-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SeparableConv1D layer #125
Comments
I might be able to do this, not quite sure if I understand it well enough to do this properly. Is |
I suggest creating AbstractSeparableConv looking to the AbstractConv, but without inheritance. If it makes sense, we merge these class hierarchies. I'll assign this ticket to you; please notify me if you will not do this. |
I will see if I can get this one done in the weekend. |
- still have to write tests, and do the 1D variant - this also fixed a bug in WeightLoader that did not load the bias weights correctly for SeparableConv2D.kt
Hi, @dosier Are you interested in continuing working on this issue? |
Currently, the support for
SeparableConv1D
is missed, and it would be great to add support for this layer. The desired PR addressing this issue should include:SeparableConv1D
(you can take inspiration from the implementation ofConv1D
andSeparableConv2D
as reference)api
moduleAlso, if needed, you can take a look at Keras documentation for
SeparableConv1D
.NOTE: for the moment, there is no need to add support for "data format" (i.e., channels last vs. channels first) in your PR; you can assume the channels are always in the last dimension.
P.S. If you want to take this ticket, please leave the comment below
P.P.S Read the Contributing Guidelines.
The text was updated successfully, but these errors were encountered: