Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Layer API simplification #233

Open
knok16 opened this issue Sep 20, 2021 · 2 comments
Open

[API] Layer API simplification #233

knok16 opened this issue Sep 20, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@knok16
Copy link
Contributor

knok16 commented Sep 20, 2021

Layer is a core concept of the library, so it will be beneficial to keep it as simple, concise, and straightforward as possible. To achieve this simplicity I suggest the next changes:

  1. Remove unnecessary logic from Layer, split it into smaller subclasses that will encapsulate one particular aspect of the Layer, convert Layer class into an interface.
  2. Split layers into 2 separate interfaces: LayerBuilder and Layer, leaving all preparation and layer construction to LayerBuilder, and making Layer immutable object that will represent a fully constructed layer.

WDYT?

@zaleslaw
Copy link
Collaborator

Great summarization of a few proposals that have been discussed in the past with you. So I suggest arranging a meeting in October with other community members to discuss it.

So, I'll arrange the meeting and invite you to come and discuss it.

I suppose that when the most part of the required Keras functionality is implemented, we could move forward to make KotlinDL more kotlinish!

@zaleslaw zaleslaw added the enhancement New feature or request label Sep 21, 2021
@zaleslaw zaleslaw added this to the 0.4 milestone Sep 21, 2021
@knok16
Copy link
Contributor Author

knok16 commented Sep 21, 2021

great! agree that it should be discussed and I'm ready to do it.

@zaleslaw zaleslaw modified the milestones: 0.4, 0.5 Feb 21, 2022
@ermolenkodev ermolenkodev removed this from the 0.5 milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants