Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expand current Dataset API #39

Open
jbaron opened this issue Feb 2, 2021 · 2 comments
Open

[Feature Request] Expand current Dataset API #39

jbaron opened this issue Feb 2, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jbaron
Copy link

jbaron commented Feb 2, 2021

Currently the dataset api allows only for simple X -> Y data sets. So one input and one output. There are many models that require more input and/or output data to be fed into the training loop.

Since other API's in KotlinDL rely on the dataset API, would it make sense to already come up with a more generic API?

Typically in the Python world the output it is either arbitrary length Tuple (so perhaps a List in Kotlin) or a Dict (which is nicer IMHO since the key gives some indication what the individual tensors are used for).

@zaleslaw
Copy link
Collaborator

zaleslaw commented Feb 4, 2021

@jbaron Thanks for the feedback. I totally agree with you. The dataset API is minimal. You shared a few tips and ideas; it could be the initial point for the development. If you have any ideas, please share them on this issue. Maybe you could share any links or notebooks with your cases to learn them in detail.

@zaleslaw zaleslaw changed the title Dataset limitations [Feature Request] Expand current Dataset API Feb 4, 2021
@jbaron
Copy link
Author

jbaron commented Feb 7, 2021

@zaleslaw I'll give it some more thoughts and see if I can come up with some examples. Perhaps better to not to just copy directly copy Python API's (and as a result use Map everywhere ;). Also it is key for many training examples that the data set can keep up with the training loop, so that often implies some sort of parallel behavior.

@zaleslaw zaleslaw added the enhancement New feature or request label Jun 2, 2021
@zaleslaw zaleslaw self-assigned this Jun 15, 2021
@zaleslaw zaleslaw added this to the 0.4 milestone Sep 13, 2021
@zaleslaw zaleslaw modified the milestones: 0.4, 0.5 Dec 15, 2021
@ermolenkodev ermolenkodev removed this from the 0.5 milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants