The accent line is very thick.

[Gabrielxd195]

System Information

Debian Sid Cinnamon

LMMS Version(s)

Nightly Version

Most Recent Working Version

Versión 1.3.0-alpha.1.629+g43fbcca9c (Linux/x86_64, Qt 5.12.8, GCC 9.4.0).

Bug Summary

I understand that the grids can be changed as you wish, and that this line marks the accentuation, but I think that this line is very thick and makes the interface look very busy, this is more noticeable when you zoom out. In addition, there is a thin line that marks every 8 bars, and this seems even more confusing to me. Shouldn't it be the other way around: let the thick line be the one that marks every 8 bars and the thin line be the one that marks the accentuation as before? I love that they implemented these grilles but the accent line is unnecessarily thick.

Google Traslator

Expected Behaviour

That the accentuation line is thinner, or that they exchange the thick accentuation line for the fine one of every 8 bars.

Steps To Reproduce

1- Open LMMS
2- Open a Project
3- Do the test by zooming out/in
4- The interface will look very busy and the patterns will be very tight.

Logs

Click to expand

Screenshots / Minimum Reproducible Project

No response

Please search the issue tracker for existing bug reports before submitting your own.

• I have searched all existing issues and confirmed that this is not a duplicate.

[Rossmaxx]

I can understand, but the problem with it is, there's no sweet spot, or it's really hard to get right. @BoredGuy1 (or @regulus79, whoever made that PR, don't exactly remember), I'm inviting you guys over. What's the best way to tackle this minor annoyance?

[regulus79]

This bug is due to an off-by-one error when drawing the coarse gridlines in TrackContentWidget.cpp.

The TrackContentWidget background is drawn using a tiled Pixmap which is 8 bars long. The coarse grid is drawn using a for loop which goes over the 8 bars and draws a vertical line for each one. This works if the coarse grid lines are 1px wide, but in the default theme, they are 2px. This is a problem, since the first grid line is cut off: only half of it shows, which is why every 8th bar line looks thin.

#7610 This can be fixed by changing the < on line 143 of TrackContentWidget.cpp to <=, since that will make it draw the very last bar line. This will also get cut off, but on the other side, so the next set of 8 bars will finish the bar line and it will look uniform.