Move Search to the Toolbar

[epwinchell]

Pre-Requisites

• the expression editor is re-written in React
• the advanced search modal is converted to React

The search/adv search box has long occupied space in the title area (even when not visible), causing some titles to wrap.

Mobile/Tablet:

Now that we've optimized the toolbar by removing History and icons from the dropdowns, I think it would be a good time to move search (as a search icon adjacent to the view buttons), which is a PF standard: https://www.patternfly.org/v3/pattern-library/forms-and-controls/toolbar/#code

Like this:

And once clicked:

Simple Search

Advanced Search (arrow or other icon would trigger the modal as it does now )

@terezanovotna @Loicavenel @martinpovolny Thoughts?

[miq-bot]

@epwinchell 'epwinchell, martinpovolny' is an invalid assignee, ignoring...

[epwinchell]

@miq-bot assign @epwinchell

[terezanovotna]

I like this!

[skateman]

I'm a little worried that without the new expresison editor this would be a little hacky to implement 😕

1. To have this in the toolbar, it needs to be ideally in react
2. If it is written in react, the button that opens the expression editor is in react
3. This implies that we open old world code from the new world
4. H.A.C.K. 😞

On the other hand if we have the new expression editor, we just have to open a new world component from another new world component, maybe even using redux.

[martinpovolny]

As @skateman wrote. This needs to be done AFTER

• the expression editor is written and
• the advanced search modal is converted to React.

Before that it's not a good idea.

[miq-bot]

@epwinchell 'epwinchell' is an invalid assignee, ignoring...

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.