-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checksum for the images #526
Comments
@simaishi Yeah I think that could work |
@chessbyte We were thinking we'll create the file during build and upload to the same server where the images are (not sure about the exact location). |
@simaishi that would be cool - then the code that builds the downloads page can validate each downloadable URL it presents against that source of truth. Let me know when there is something up there and I can make a PR here to validate against it. |
There's already the ETag header on the file that can be used to validate the MD5 sum of the file. Is that good enough? |
ETag is a part of the HEAD request, and I think you can also get the upload date |
|
Ah, For the nightly build date (#655), we probably want to get it from the file name as build date isn't upload date? And if we want to validate what we built is what was uploaded, then we'll need to generate something at build time, but that's a different issue, I guess. |
I'm less concerned about the validation, though I could see an MD5 (ETag is MD5) generated on the build side and uploaded. MD5 isn't a secure hash, however it's good enough to ensure that someone didn't get a corrupted download. |
Agreed, the original request is for users to be able to validate images they downloaded. |
@bdunne If we change hosting does the new hosting have ETag, and, if so, what hash function does it use? |
The alternative hosting provider that I'm looking at is the same (ETag using MD5sum) |
@hayesr We discussed this a while ago, but not sure where we left off... A few things we discussed were:
The text was updated successfully, but these errors were encountered: