Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS variable substitution does not work in base/base #19

Open
MarauderXtreme opened this issue Feb 27, 2022 · 2 comments
Open

SCSS variable substitution does not work in base/base #19

MarauderXtreme opened this issue Feb 27, 2022 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed Theming Things related to SCSS or the layouts

Comments

@MarauderXtreme
Copy link
Owner

I define in assets/stylesheets/base/base various CSS var declaration to ease later light theme integration (relates #5).
To make it easier to develop I tried to parametrise these declarations with SCSS variables for various colours.
Unfortunately those do not get translated but rather put 1:1 into the resulting CSS.

This behaviour seems odd whereas every other stylesheet gets treated as expected.
It either relates to CSS var declarations being handled differently by SCSS or the :root selector is not recognised.

This needs further investigation.

@MarauderXtreme MarauderXtreme added bug Something isn't working help wanted Extra attention is needed Theming Things related to SCSS or the layouts labels Feb 27, 2022
@MarauderXtreme MarauderXtreme added this to the Public Release milestone Feb 27, 2022
@MarauderXtreme MarauderXtreme self-assigned this Feb 27, 2022
@MarauderXtreme MarauderXtreme pinned this issue Feb 27, 2022
@MarauderXtreme
Copy link
Owner Author

This apparently includes all processing.
I tried to use asset_url() from jekyll-assets but it just prints it literally.
I have the suspicion that this either comes from a mishandling in jekyll-assets or sprockets.

@MarauderXtreme
Copy link
Owner Author

Removing this for now from public release milestone as it seems not fixable given the current state of jekyll-assets.

@MarauderXtreme MarauderXtreme removed this from the Public Release milestone Apr 18, 2023
@MarauderXtreme MarauderXtreme removed their assignment Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed Theming Things related to SCSS or the layouts
Projects
None yet
Development

No branches or pull requests

1 participant