-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MyMeta] Add new block – functionality & templates #264
Comments
I'd like to take a stab at this, from a design POV. Where can I see the "add new section" button exactly? Couldn't find it in my profile page once logged in. I realize that this in itself might not be essential for designing these section templates, but can't help my curiosity :) |
Thanks @peth-yursick – this helps a lot to get some context around the problem at hand :) |
@davort have you made progress on this? If there's no frontend builder effort here, i'd be up for building out these templates based off your designs/wireframes. |
Hey @luxumbra - no progress to speak of yet, but there might be in near future, now that you're kindly offering to help! 😊 |
@peth-yursick |
Let's just start with two? That one is probably both simplest & most important to implement: allow people to embed anything they want. The next ones on the list (though not necessarily second most important) is "credentials & past work". Clicking "add new section" could open a prompt offering a few options, one of which is functional (link embedding) & the others that would serve more like "thank you for voting for this feature to get implemented next :)". But that's just a random weird user testing/analytics idea I just had 😂 |
Thanks @peth-yursick, sounds good! We'll start with those two templates then. @luxumbra – seems like we have a 2-part challenge here:
I'll get down to making a quick wireframe and run it by you ASAP. |
Maybe for adding, clicking the 'New Block' button loads a list of block types that are available, the user selects the type and the relevant form is loaded into the 'new block' container and displayed on save. Similar flow for editing but with an edit/settings icon, top right of the section, that when clicked, loads the edit form in the container.
I look forward to having a look! 😄 |
Link to initial wireframe from @davort https://www.figma.com/file/zDHqledo5H2aKR3KDvbur8/Meta-Game?node-id=6818%3A33 |
I updated the wireframe, and made a quick prototype: https://www.figma.com/proto/zDHqledo5H2aKR3KDvbur8/Meta-Game?page-id=6814%3A1840&node-id=6818%3A33&viewport=600%2C322%2C0.47077539563179016&scaling=scale-down @luxumbra – please take a look and check the questions I listed at the bottom right corner of the last screen. Are any of the questions unnecessary? Are there any missing? Which ones would you prefer having mockups for, before you start building this? Let me know! |
Thanks for the update @davort 👍🏻 I'll take a closer look this afternoon. One thing I did think on first look was that it would be nice to have the preview like you had in the modal version. So it loads the preview below the input when the user inserts the embed URL? @peth-yursick any thoughts on this, ser? |
|
Sorry for the delay @davort. We are going to want to render what the preview would display as the embed anyway when the user saves their link. This would just be making it more async. |
Good thinking. Users are probably more willing to wait for the preview to render during the process of adding the block than after they hit the "Save" button, anyways. This way, when they save it, it will be instantaneous. |
Hey, @peth-yursick !
|
@davort - We will be grabbing the content of the relevant Open Graph data from the Meta tags ( |
Thanks @luxumbra! I've updated the mockups: https://www.figma.com/file/zDHqledo5H2aKR3KDvbur8/?node-id=6814%3A1840 And here's a quick prototype for the happy path: https://www.figma.com/proto/zDHqledo5H2aKR3KDvbur8/Meta-Game?page-id=6814%3A1840&node-id=6818%3A33&viewport=600%2C322%2C0.47077539563179016&scaling=min-zoom Notes and questions
|
Looking good.
Nice. I guess i thought we'd just add the url they pasted as it might be a link to a referral or something but we could display the
Sweet!! With regards to errors:
Smashing!! 🙂 |
@luxumbra – please check out the Edit/Delete flow in the prototype 👉 "Add Block" on Figma Let me know your thoughts! cc @peth-yursick |
I like this @davort 👍🏻 Maybe it would be good to add a "success/error" notice once delete is pressed, before the section is removed or if it fails? 🤔 |
This reminds me, at some points I'd like to go through & put in more thinking around all the text on MyMeta, on each step, prompts, error messages etc. to align it with MetaGame's voice.. Is it easier if I do that now or do a full run-through later? |
Whatever we can start now, so that there's less to do later, is better started now IMHO.
|
Hey @luxumbra – please check out the updated prototype: "Add Block" on Figma Alternatively, here is a quick take on the error messaging design: Error message (Delete block) on Figma → please note that this particular error message text doesn't make much sense, so let's just focus on the layout for now ;) |
I think it would definitely help if we kept track of it or make easy queryble or something. We don't but it's been brought up a few times lately & I've been thinking about it a lot.. I have a bookmark on writing that by mailchimp but I'll also see what other ways these things are written. Alternatively, we can get someone who actually knows how to write these things, but that someone probably won't know metagame's voice as well as I do so it might end up even more work 🤷♂️ |
@peth-yursick – thanks for the added context. My 2 cents:
|
@davort, a little update for you - I have made a start building out this component and have got the embedded view styled and displaying metadata from a given URL. I'll be looking at the rest of the flow over the next couple of days. |
Any update on this? |
Very nice demo, @luxumbra. When is this going to be live? |
I hit blockers on this and passed it to @mquellhorst some time back in July. I am not sure what the current status is. I reckon one of the newer builders would like to take it on if it needs someone to continue on it. |
@vidvidvid @Udit-takkar @polimyl @tommymaher15 this is another one that needs some attention to get it finished. Another one I started and ran out of talent. Will be great to have someone look at it when other pressing issues have been crossed off the list. |
Need any help with this @dan13ram? |
@peth-yursick Thanks for following up. I did have some trouble getting into this issue, but finally I've made some progress. This is still very much a WIP. But I think I've laid down the foundations to slowly start adding options to embed new types of sections to users' profiles. |
Do you have the code for this awesome demo ? If so, could you share it with me ? |
It was in a feature branch when i handed the issue over to @mquellhorst. Here you go ser feature/264-embed-url-section. To make finding stuff easier, I tend to use the issue number as the first part of a branch name and as it was never merged, it didn't get deleted. 🙌🏻 |
Thank you @luxumbra 🙏🏽 |
No progress since. What do you think is a good next custom section that we can implement @peth-yursick ? Past work? Custom Questions? We also require design to go ahead with these custom sections. @davort do you have time to provide input for this? |
@dan13ram Easiest IMHO would be to go with "custom questions", both for input and later for displaying in profiles. For input, it would boil down to:
On the "front" we can then show full Lemme know if this makes sense, or if you'd like me to put together a quick sketch? Any other feedback is also welcome, of course :) |
@davort Thank you! I'd like to understand a little more in detail. Are the questions posted by visitors to the profile or are the questions posted by the player themself? Will the answers be public to all players or only to the player themself ? Will each block be limited to a single question or multiple questions ? (If multiple, the blocks may end up becoming unusually long?) |
@dan13ram I imagined it as a "custom text box" where only the profile owner can post what they think is relevant and/or special to them. Would anybody want to contact a player, they ought to use other channels for that IMHO - Discord, email... We don't want to open that can of worms — think abuse and misuse of different kinds, if we'd enable general public to post stuff on anyone's profile page. |
Interesting @davort. So both the "question" and the "answer" are something written by the user. Again though,
Totally agree! |
@dan13ram It's likely I am overthinking this. Perhaps better we'd referred back to the opening description by @peth-yursick Of all the options listed there, I suggest we add these next:
If we were to go with the above options, what can we offer in the way of formatting text? Markup or a WYSIWYG editor of some sort? I remember us running into the same question when we were initially discussing #657 What are your thoughts on this? |
Wait, "next" section? You're saying the "embed links" was done? 😱 I like the idea of having a blank block, doesn't even need to be a question necessarily. It can just be "block title" & "block body" 🤷♂️ The way it could work: you click "new block", by default you start typing but there's also a dropdown or something with the suggested questions/titles:
Eventually, these could be sorted based on how often other people are using them & custom ones added to the bottom. For formatting, we could use the same thing we're using for Quests, though that may be too many options for a small box... 🤔 |
Yes @peth-yursick That PR was merged a while back to
I'll take a crack at this. Should be relatively simple to accomplish :D |
Migrating to #1512 |
We need people to be able to embed more things into their MyMeta profiles.
Right now the only options are the default profile creation elements but we need to make it customizable.
The simplest "add new block" template to add will be an ability to embed links.
More "add new block" template options:
There are more & more reputation & identity protocols as well as web2 & web3 platforms that have data that may be interesting for people to plug into their MyMeta profiles.
The meta solution may be to start integrating more things into MyMeta rather than just looking to integrate MyMeta in other places. If we can aggregate all of data points from different platforms into a single user profile, that could make it the default profile for people 🤷♂️
More thoughts in this thread.
The text was updated successfully, but these errors were encountered: