Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum sound duration check? #180

Open
PotcFdk opened this issue Sep 29, 2018 · 0 comments
Open

Maximum sound duration check? #180

PotcFdk opened this issue Sep 29, 2018 · 0 comments

Comments

@PotcFdk
Copy link
Member

PotcFdk commented Sep 29, 2018

So this commit gave me an idea:

How about adding a configurable maximum sound duration check to the preprocessor?
It would check all files if they are longer than X seconds, and if so, they would be marked as invalid unless they are explicitly whitelisted somewhere.

The possible advantages:

  • Makes it harder for accidental mistakes in editing to go unnoticed
    (I've committed the entire audio stream instead of just the correct part before and didn't notice it for quite some time)
  • Forcing people to explicitly whitelist costs more willpower/effort -> more careful consideration -> reduced amount of overlong sounds
  • A whitelist makes it easy to see, inspect, audit and re-consider the violations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant