You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The package has turned out quite clean with nice abstractions. The ideas from earlier versions have been distilled to an elegant set of types and functions, with some new additions.
The elephant in the room however is the Protein submodule, with plenty of arbitrary design decisions having been made. Having support for proteins in the package natively is convenient, but PDB IO basically requires us to have 2 dependencies: BioStructures for robust PDB reading, and PDBTools for easy writing. BioStructures writing is a pain in the ass, as we'd basically need to construct an entire Structure with models, chains, residues from scratch using a Backbone and some extra vectors like amino acids and residue numbers.
Nevertheless, we could technically support proteins with a BioStructures extension, for example by defining a Backbone(chain::BioStructures.Chain, residue_selectors...) constructor or something, keeping the core package clean.
Alternatively, there could be a whole other package for protein stuff.
The text was updated successfully, but these errors were encountered:
The package has turned out quite clean with nice abstractions. The ideas from earlier versions have been distilled to an elegant set of types and functions, with some new additions.
The elephant in the room however is the Protein submodule, with plenty of arbitrary design decisions having been made. Having support for proteins in the package natively is convenient, but PDB IO basically requires us to have 2 dependencies: BioStructures for robust PDB reading, and PDBTools for easy writing. BioStructures writing is a pain in the ass, as we'd basically need to construct an entire Structure with models, chains, residues from scratch using a Backbone and some extra vectors like amino acids and residue numbers.
Nevertheless, we could technically support proteins with a BioStructures extension, for example by defining a Backbone(chain::BioStructures.Chain, residue_selectors...) constructor or something, keeping the core package clean.
Alternatively, there could be a whole other package for protein stuff.
The text was updated successfully, but these errors were encountered: