New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming thread. #46

Open

murrellb opened this issue Jan 21, 2025 · 0 comments

Member

murrellb commented Jan 21, 2025

Package has grown organically and needs some things to be renamed, sometimes for consistency and sometimes because the initial names were bad.

Definite:

internal_message_init! -> allocate!
getleaflist -> leaves
getnodelist -> nodes
getnonleaflist -> internal_nodes
partition_list -> partition_inds

Open questions:

Partition? This is consistent with HyPhy usage but maybe there are better options.
partition2obs?

@nossleinad Please make your suggestions and I'll curate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment