Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Use native Elixir DateTime, Date #47

Open
johnwunder opened this issue Oct 9, 2016 · 5 comments
Open

Use native Elixir DateTime, Date #47

johnwunder opened this issue Oct 9, 2016 · 5 comments

Comments

@johnwunder
Copy link

johnwunder commented Oct 9, 2016

Is there any reason MarcoPolo doesn't use the native Elixir DateTime and Date types? Was it just done before they were added?

Would seem to be more convenient, and I'd be happy to PR to fix, just don't want to spend time on it if there was some other reason not to.

@simonewebdesign
Copy link

Was it just done before they were added?

Exactly. I think you can go for a PR if you want. :)

@whatyouhide
Copy link
Contributor

A PR would be fantastic @johnwunder :D Feel free to ping if you need any help along the way!

@johnwunder
Copy link
Author

Cool, I'll give it a shot (didn't forget about this, just other job stuff got in the way).

@whatyouhide
Copy link
Contributor

Ping @johnwunder? :)

@johnwunder
Copy link
Author

Sorry there's a pull request #48 which is failing now because the CI tests against an Elixir version before they were added. You could in theory write conditional logic to use either the native types (if available) or the custom types but since I'm just using the newer Elixir version I couldn't justify spending the time to do that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants