Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split nightly-rosetta-*-build-test.yaml into build and test files #376

Open
DwarKapex opened this issue Nov 16, 2023 · 1 comment
Open

Comments

@DwarKapex
Copy link
Contributor

No description provided.

@terrykong
Copy link
Contributor

Initially the workflows were separate, but they were merged in order to allow the publishing of the :latest tag to be contingent on the test results.

We can revisit when there's BW, but I think when splitting, the container publishing logic should be:

  1. Run rosetta build workflow
    1. publish :nightly-YYYY-MM-DD tag if build successful
  2. Run rosetta test workflow on :nightly-YYYY-MM-DD (if workflow_run), :latest (if workflow_dispatch)
    1. publish :latest if tests successful

As an aside, by re-splitting the workflows, we'll be at the limit for workflow run chaining (3 levels max). Not a blocker since I don't think we'll go beyond that in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants