Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: is cython used at run time? at all? #684

Open
asarhaddon opened this issue Dec 16, 2023 · 2 comments
Open

dev: is cython used at run time? at all? #684

asarhaddon opened this issue Dec 16, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@asarhaddon
Copy link
Contributor

Hello.
Cython is listed in setup.cfg and requirements.txt.
Automated tools building the Debian package deduce the run-time dependencies from them.
Cython does not seem to be used at all, but even if it is, it is most probably only useful at build time.
Could it be removed from these lists and handled separately, like the dependencies for tests?
Thanks.
@asarhaddon asarhaddon added the enhancement New feature or request label Dec 16, 2023
@hosiet
Copy link

hosiet commented Jan 23, 2025

The mentioning of Cython has been completely dropped in 588c854#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 . This change has not been reflected in a released version yet.

Please consider closing this issue once nanovna-save makes another release.

@asarhaddon
Copy link
Contributor Author

We may even close the issue now if that fits your workflow. A patch already removes cython from the Debian package.
Also, next release will not be packaged any time soon because uv is quite complex to package properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hosiet @asarhaddon