Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: dependencies defined on multiple places #749

Open
yarda opened this issue Jan 6, 2025 · 2 comments
Open

bug: dependencies defined on multiple places #749

yarda opened this issue Jan 6, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@yarda
Copy link
Contributor

yarda commented Jan 6, 2025

Bug Report

NanoVNA-Saver version:
nanovna-saver-0.6.8

Current behavior:

Dependencies are defined in setup.cfg, requirements.txt, and pyproject.toml. It should be defined only on one place probably pyproject.toml.

Also I think the deps are uselessly strict so it complicates distro packaging. I had to patch the strict version requirements in order to package it into Fedora. See e.g. https://bugzilla.redhat.com/show_bug.cgi?id=2332187

Expected behavior:

Dependencies defined only in one place and probably relaxed not to require strict versions, but maybe the lowest version and all new versions of packages.

Steps to reproduce:

Check the content of the setup.cfg, requirements.txt, and pyproject.toml.

Related code:

Other information:

https://bugzilla.redhat.com/show_bug.cgi?id=2332187

@yarda yarda added the bug Something isn't working label Jan 6, 2025
@barjac
Copy link

barjac commented Jan 6, 2025

I guess you did not see #744 :)

@redrathnure
Copy link
Contributor

Trying to solve this problem in #752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants