Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

403 Errors on some pull requests #119

Open
Lassulus opened this issue Oct 18, 2024 · 2 comments
Open

403 Errors on some pull requests #119

Lassulus opened this issue Oct 18, 2024 · 2 comments

Comments

@Lassulus
Copy link
Member

Lassulus commented Oct 18, 2024

We see an increase in 403 errors

NixOS/nixpkgs#348977 (comment)
NixOS/nixpkgs#349062 (comment)

which seems indicative of Rate Limiting.
From the GitHub docs:

If you exceed your primary rate limit, you will receive a 403 or 429 response, and the x-ratelimit-remaining header will be 0. You should not retry your request until after the time specified by the x-ratelimit-reset header.

If you exceed a secondary rate limit, you will receive a 403 or 429 response and an error message that indicates that you exceeded a secondary rate limit. If the retry-after response header is present, you should not retry your request until after that many seconds has elapsed. If the x-ratelimit-remaining header is 0, you should not retry your request until after the time, in UTC epoch seconds, specified by the x-ratelimit-reset header. Otherwise, wait for at least one minute before retrying. If your request continues to fail due to a secondary rate limit, wait for an exponentially increasing amount of time between retries, and throw an error after a specific number of retries.

@Scriptkiddi
Copy link
Collaborator

Jan 04 10:01:57 nixpkgs-merge-bot 0wvdfqcbq5lv77qw1pjn7zzabhklv4r9-nixpkgs-merge-bot[751938]: DEBUG: rate limit: 12500
Jan 04 10:01:57 nixpkgs-merge-bot 0wvdfqcbq5lv77qw1pjn7zzabhklv4r9-nixpkgs-merge-bot[751938]: DEBUG: rate limit remaining: 12465
Jan 04 10:01:57 nixpkgs-merge-bot 0wvdfqcbq5lv77qw1pjn7zzabhklv4r9-nixpkgs-merge-bot[751938]: DEBUG: rate limit used: 35
Jan 04 10:01:57 nixpkgs-merge-bot 0wvdfqcbq5lv77qw1pjn7zzabhklv4r9-nixpkgs-merge-bot[751938]: DEBUG: rate limit reset: 1735987393

I dont think we have ratelimit issues, but lets see next time what happens when we get a 403

@Scriptkiddi Scriptkiddi changed the title Rate Limit exceeded 403 Errors on some pull requests Jan 6, 2025
@Scriptkiddi
Copy link
Collaborator

we are not hitting the ratelimit and are still getting 403 errors. We added a tracking issue to link on api failure to further investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants