Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing of external libraries #566

Open
fzimmermann89 opened this issue Nov 28, 2024 · 1 comment
Open

typing of external libraries #566

fzimmermann89 opened this issue Nov 28, 2024 · 1 comment

Comments

@fzimmermann89
Copy link
Member

Some of our dependencies do not direclty include type hints. We currently ignore them in mypy.
We could install the type stubs (scipy, h5py, pydicom) if available.
We those not available (ismrmrd, pypulseq), we could generate our own stubs (using genstubs and some manual fixing) and put them in a stubs directory.
This would allow mypy to check if our code uses these functions correctly. currently, mypy assumes everything from these libraries to be Any and does not check anything.

@fzimmermann89
Copy link
Member Author

fzimmermann89 commented Nov 28, 2024

..this would also require some minor changes to our code to fix some of our typing errors currently hidden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant