First Age: list of observed issues

[Porkenstein]

These issues have been observed in the past and need to be investigated:.

Gameplay bugs:

• purge province events not always functioning
• abdicating children during random character fix event are killed and high lords of talath annui under the march of maedhros are being auto murdered. Look into the new age modifying commands instead of replacing with random characters.
• plot_slay_character usage is flaky
• job_lord_spiritual needs its cb references restored
• smiths might be filling up courts
• monster units need tactics
• external realm inheritance for off-map realms like Valinor and Helkarth
• ensure nobody is stuck in visiting court mode due to death of host
• can_be_overthrown trigger does not work
  -half elf traits aren't working
• remove beren's beard
• can't colonise provinces with 0 settlements. Population and colonisation mechanics are a bit disjoint and need to be consolidated with events.
• 'no water system' and 'empty halls' can be built. Need to make an on_action where they're automatically added when a dwarf gains a new holding.
• morgoth abdicated once
• Non-orks are still marrying orks. only sticks with religion_group_melkor since they aren't killed immediately. Need to rewrite the seduction event localization to be about romance, and end them in marraige so AI elves actually procreate. Look into the hard 'do not marry' flag that was added for smiths back in MnM
• 'smith' appearing as dynasty for some races still
• wilderness with 0 provinces become the religion and culture of their holder, which creates provinces with valar and umaiar religion when owned by sauron and morgoth. Can be problematic and looks really weird.
• saw a crash related to laws, possibly related to primary_type and unlanded titles.

Things that were causing crashes and were therefore removed a while ago:

• mapitems.gfx
• custom province map borders
• coats of arms
• trait replacement
• diseases
• nomadic hosts. were also causing strange history bugs

Graphical issues:

• face tearing on elves. Some chins and cheeks look odd and need to be redone.
• all cultures and all relgion types need temple holding graphics

Localisation issues:

• lunatic dooms of judgement are too long
• ' we have been attacked in .'
• [Title Adjective] Host for dynamic mercenaries doesn't always to work
• remove all appearances of the phrase 'peasants'
• disease localisations are still inconsistent