Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion]: 是否要给桌面端增加窗口控制按钮 #515

Open
1 task done
ErBWs opened this issue Dec 25, 2024 · 9 comments · May be fixed by #529
Open
1 task done

[Discussion]: 是否要给桌面端增加窗口控制按钮 #515

ErBWs opened this issue Dec 25, 2024 · 9 comments · May be fixed by #529
Labels
question Further information is requested

Comments

@ErBWs
Copy link
Contributor

ErBWs commented Dec 25, 2024

issue 内容

最先讨论于 #514

增加窗口控制按钮的效果如下,欢迎给出你的看法

Windows 顶部标题栏是黑色的因为我系统是深色模式

Image

Image

Image

image image image

提交前确认

  • issue 列表中,没有我的新功能需求 / 问题
@Predidit Predidit added the question Further information is requested label Dec 25, 2024
@ErBWs ErBWs changed the title [Discussion]: 是否要给 macOS 增加红绿灯控制按钮 [Discussion]: 是否要给 macOS 增加窗口控制按钮 Dec 25, 2024
@Predidit Predidit pinned this issue Dec 25, 2024
@AoEiuV020
Copy link
Contributor

支持,最大化我不用,但方便的关闭和最小化感觉不错, 尤其最后一张图,能直接在播放器页面关闭的话就方便多了,
至于好不好看,感觉图2红绿灯在返回键上方看着意外的有点突兀,不知道是不是额头太高了, 其他还不错,

@ErBWs
Copy link
Contributor Author

ErBWs commented Dec 27, 2024

不知道是不是额头太高了

除了有 side_menu 的界面其他界面约等于把默认 title bar 颜色融合在界面里,所以会显得比较高

@zdejianz
Copy link

支持

@ErBWs
Copy link
Contributor Author

ErBWs commented Jan 11, 2025

也许应该把这个 issue 改为所有桌面平台的窗口控制按钮

macOS 用户比较少,Windows 用户根据以前的 issue 来看不少人想要添加最小化和全屏按键

或许可以为所有桌面平台添加控制按钮并添加设置项允许自由选择显示或不显示

只不过 macOS 由于其控制按钮比较特殊,将其融合在界面内是常见实现

@ErBWs ErBWs mentioned this issue Jan 22, 2025
@bggRGjQaUbCoE
Copy link
Contributor

最大/小化还是挺实用的

@boa-z
Copy link

boa-z commented Jan 23, 2025

支持macOS默认,感谢

@garylkz
Copy link
Contributor

garylkz commented Jan 27, 2025

那个虽然有点跑题了,不过有考虑也给 GNOME 加窗口控制吗?

Image

@ErBWs
Copy link
Contributor Author

ErBWs commented Jan 28, 2025

那个虽然有点跑题了,不过有考虑也给 GNOME 加窗口控制吗?

Image

我猜测大多数桌面用户都想要窗口控制,以前的相关 issue 有不少。

取决于作者愿不愿意合并 PR

我可以做 macOS 的窗口控制按钮融合,但是做不了其他桌面平台的

@ErBWs
Copy link
Contributor Author

ErBWs commented Jan 31, 2025

这是三个平台加了控制按钮的构建,可以在 设置-外观设置-使用系统标题栏 开启,默认关闭,重启生效

只有 macOS 是透明标题栏,Windows 和 Linux 没有本地环境不好开发。macOS 控制按钮在左边天生方便融合透明标题栏

Linux
macOS
Windows

@ErBWs ErBWs changed the title [Discussion]: 是否要给 macOS 增加窗口控制按钮 [Discussion]: 是否要给桌面端增加窗口控制按钮 Feb 1, 2025
@ErBWs ErBWs linked a pull request Feb 1, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants