Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate all internal rollup plugin usages to Rollup config #1391

Open
thescientist13 opened this issue Jan 19, 2025 · 0 comments
Open

consolidate all internal rollup plugin usages to Rollup config #1391

thescientist13 opened this issue Jan 19, 2025 · 0 comments
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

Enhancement

Summary

Currently some Greenwood plugins provide their own Rollup plugins, but I think it would make more sense if those were all just declared "top level" in rollup.config.js since we're already doing that for other Rollup plugins like CommonJS and NodeJS resolution. I often forget that Greenwood has these Rollup plugins tucked away

Details

I think both of these just can get moved / imported into [getRollupConfigForBrowserScripts]

  1. Node Modules - https://github.com/ProjectEvergreen/greenwood/blob/v0.31.0-alpha.5/packages/cli/src/config/rollup.config.js#L577
  2. Terser - https://github.com/ProjectEvergreen/greenwood/blob/v0.31.0-alpha.5/packages/cli/src/plugins/resource/plugin-standard-javascript.js#L76
@thescientist13 thescientist13 added CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers labels Jan 19, 2025
@thescientist13 thescientist13 added this to the 1.0 milestone Jan 19, 2025
@thescientist13 thescientist13 changed the title consolidate all internal rollup plugin usages to _rollup.config.js_ consolidate all internal rollup plugin usages to Rollup config Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant