Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend cmdlet Get-IShEvent with IshBackgroundTask parameter overload as Add-IshBackgroundTask companion #194

Open
4 tasks
ddemeyer opened this issue Jun 19, 2024 · 0 comments

Comments

@ddemeyer
Copy link
Contributor

The request is to make it possible to easily catch and follow-up on the Events generated of a new BackgroundTask (see recent #193)

Add-IShBackgroundTask ... | Get-IShEvent
#or
$justCreatedBackgroundTask = Add-IShBackgroundTask ...
$justCreatedBackgroundTask | Get-IShEvent
Get-IshEvent -IshBackgroundTask $justCreatedBackgroundTask
  • Start from ParameterSetName IshEventsGroup, same parameters like EventLevel, MetadataFilter, RequestedMetadata and of course IshSession
  • Just like -IshEvent is an array, so is -IshBackgroundTask ... if you do a group request you just get them concatenated as already implemented when offering multiple inputs on -IshEvent ... For IshEvent you go to _retrievedIshEvents , but for IshBackgroundTask you can immediately skip to progressRefs which we should rename to a class property _retrievedProgressRefs as they can already be filled up from the ProcessRecord function
  • Extend inline tripple-slash documentation for Get-Help usage
  • Add Pester test
/// <summary>
/// <para type="description">The <see cref="IshEvent"/>s that need to be handled.</para>
/// </summary>
[Parameter(Mandatory = true, ValueFromPipeline = true, ParameterSetName = "IshEventsGroup")]
public IshEvent[] IshEvent { get; set; }
@ddemeyer ddemeyer added this to the v8.1 milestone Jun 19, 2024
@ddemeyer ddemeyer removed this from the v8.1 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant