Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Piece does not work anymore with TMDB #212

Open
Soitora opened this issue Aug 24, 2023 · 8 comments
Open

One Piece does not work anymore with TMDB #212

Soitora opened this issue Aug 24, 2023 · 8 comments

Comments

@Soitora
Copy link

Soitora commented Aug 24, 2023

Discussed with @Jaynator495 and @reconman in April on the Discord

Might have broken in #174
1.3.21 works, 1.3.22 and later doesn't work

This is with TheMovieDB due to their absolute numbers while keeping season format

I noticed this again yesterday when I watched One Piece and it updated to episode 9600 or something

image

Soitora added a commit to RickDB/PlexAniSync-Custom-Mappings that referenced this issue Aug 24, 2023
Due to a change in code a few months ago, One Piece no longer works correctly

Until this is fixed, it can't be kept.

RickDB/PlexAniSync#212
@buthed010203
Copy link

buthed010203 commented Sep 18, 2023

A bit of a hack but maybe there could be an optional boolean added to the mapping schema that could toggle between the current logic of summing the watch counts of seasons mapped to the same AL id (when no mapped_start is specified) and simply taking the max watched episode id of any of the mapped seasons.

if mapped_start != 1:
match.watched_episodes = plex_season.watched_episodes - mapped_start + 1
else:
match.watched_episodes += plex_season.watched_episodes

Edit: What i'm currently doing is adding start: 2 on every season to make it take the top path which works. It's off by one episode in AL now but it's certainly better than keeping it up to date manually.

@rcdailey
Copy link

rcdailey commented Nov 5, 2023

I'd like to share that I also had trouble with One Piece. here's the logs:

[PLEX] Retrieving anime series from section: Anime Series
[PLEX] Found 361 anime series in section: Anime Series
[PLEX] Found matching anime series
[PLEX] Retrieving watch count for series
[PLEX] 118 episodes watched for One Piece season 17
[PLEX] 33 episodes watched for One Piece season 18
[PLEX] 98 episodes watched for One Piece season 19
[PLEX] 14 episodes watched for One Piece season 20
[PLEX] 191 episodes watched for One Piece season 21
[PLEX] Found 1 watched series
[ANILIST] Matching Plex series to Anilist
[ANILIST] --------------------------------------------------
[ANILIST] Failed to find valid season title match on AniList for: One Piece season 17
[ANILIST] Failed to find valid season title match on AniList for: One Piece season 18
[ANILIST] Failed to find valid season title match on AniList for: One Piece season 19
[ANILIST] Failed to find valid season title match on AniList for: One Piece season 20
[ANILIST] Failed to find valid season title match on AniList for: One Piece season 21

@Ninelpienel
Copy link

Still no proper solution to the problem?

@reconman
Copy link
Collaborator

I patched PlexAniSync so TMDB One Piece works with a mapping like this:

  - title: "One Piece"
    seasons:
      - season: 1
        anilist-id: 21
      - season: 2
        anilist-id: 21
      - season: 3
        anilist-id: 21
      - season: 4
        anilist-id: 21
      - season: 5
        anilist-id: 21
      - season: 6
        anilist-id: 21
      - season: 7
        anilist-id: 21
      - season: 8
        anilist-id: 21
      - season: 9
        anilist-id: 21
      - season: 10
        anilist-id: 21
      - season: 11
        anilist-id: 21
      - season: 12
        anilist-id: 21
      - season: 13
        anilist-id: 21
      - season: 14
        anilist-id: 21
      - season: 15
        anilist-id: 21
      - season: 16
        anilist-id: 21
      - season: 17
        anilist-id: 21
      - season: 18
        anilist-id: 21
      - season: 19
        anilist-id: 21
      - season: 20
        anilist-id: 21
      - season: 21
        anilist-id: 21
      - season: 22
        anilist-id: 21

@Ninelpienel
Copy link

Wow, thank you!

@Ninelpienel
Copy link

Oh, does this also work on other series? Like Hunter x Hunter?

@buthed010203
Copy link

@reconman thanks for fixing the episode counting so I no longer need the start: 2 hack

@reconman
Copy link
Collaborator

Oh, does this also work on other series? Like Hunter x Hunter?

Yes if you provide a similar mapping to the one I posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants