Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavenBuild: Set -X flag when verbose: true #4608

Closed
LukasHeimann opened this issue Oct 2, 2023 · 8 comments
Closed

mavenBuild: Set -X flag when verbose: true #4608

LukasHeimann opened this issue Oct 2, 2023 · 8 comments
Labels
stale marks stale issues and pull requests

Comments

@LukasHeimann
Copy link
Contributor

Hi everyone,

In my project, I'm using the mavenBuild step. However, recently something went wrong in the pipeline, and maven was giving me an error log. Being maven, it doesn't give the full error logs by default, but offers a -X switch to do so (see also https://books.sonatype.com/mvnref-book/reference/running-sect-options.html#:~:text=6.1.9.%C2%A0Controlling%20Maven%E2%80%99s%20Verbosity).

However, it seems like piper doesn't allow to pass arbitrary flags to maven in mavenBuild. I guess there are valid reasons to do so, but in this case it might be a good idea to tie the verbosity of maven to the existing verbosity setting within piper. If verbose is true, the -X flag should be appended to the maven configuration here: https://github.com/SAP/jenkins-library/blob/master/cmd/mavenBuild.go#L42

Please let me know if there is another way through which I can set the -X flag. Unfortunately, I can't seem to reproduce the particular issue with my maven configuration locally, so I'm hoping for your input here.

Kind regards
Lukas

Copy link
Contributor

github-actions bot commented Dec 2, 2023

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Dec 2, 2023
@LukasHeimann
Copy link
Contributor Author

Hi @SAP/jenkins-library-team, can someone have a look at this?

@github-actions github-actions bot removed the stale marks stale issues and pull requests label Dec 7, 2023
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Feb 5, 2024
@LukasHeimann
Copy link
Contributor Author

I still think this is relevant

@github-actions github-actions bot removed the stale marks stale issues and pull requests label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Apr 6, 2024
@LukasHeimann
Copy link
Contributor Author

I still think this is relevant

@github-actions github-actions bot removed the stale marks stale issues and pull requests label Apr 9, 2024
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Jun 8, 2024
Copy link
Contributor

Issue got stale and no further activity happened. It has automatically been closed. Please re-open in case you still consider it relevant.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale marks stale issues and pull requests
Projects
None yet
Development

No branches or pull requests

1 participant