fix(detectExecute): logic of fetching golang private packages #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #4595 a typo was committed that prevents Go private packages from being correctly set up in the `detectExecute` step
silvestre
changed the title
|
@akram8008 @anilkeshav27 @andrew-kireev: As authors/reviewers of the original PR - may I ask you to review this fix? |
akram8008
approved these changes
Nov 29, 2023
anilkeshav27
approved these changes
Nov 29, 2023
| @@ -140,7 +140,7 @@ func detectExecuteScan(config detectExecuteScanOptions, _ *telemetry.CustomData, | |||
| log.Entry().WithError(err).Warning("Failed to get GitHub client") | |||
| } | |||
|
|
|||
| if config.PrivateModules == "" && config.PrivateModulesGitToken != "" { | |||
| if config.PrivateModules != "" && config.PrivateModulesGitToken != "" { | |||
|
Kudos, SonarCloud Quality Gate passed!
|
|
/it-go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4595 a typo was committed that prevents Go private packages from being correctly set up in the
detectExecutestepChanges