Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-plugin-streamline documentation not updated to Babel6 #343

Open
rnybergh opened this issue Nov 19, 2016 · 2 comments
Open

babel-plugin-streamline documentation not updated to Babel6 #343

rnybergh opened this issue Nov 19, 2016 · 2 comments
Labels

Comments

@rnybergh
Copy link

The documentation for the babel-plugin-streamline plugin is not up to date, it includes the .babelrc example with the "extra" that has been removed in Babel6.

The documents also refer to Babel5:
"The callbacks runtime of streamline needs the regenerator plug-in which is included by default in babel 5.x."
The line above would also require some clarification. How should the plugin be setup so that this warning does not occur:
"The regenerator/runtime module is deprecated; please import regenerator-runtime/runtime instead."
(or does it require an update of the plugin code?)

@rnybergh
Copy link
Author

rnybergh commented Nov 19, 2016

The .babelrc should at least include this, right?

    "plugins": [
        ["streamline", {
            "runtime": "callbacks"
        }]
    ]

@bjouhier
Copy link
Member

@rnybergh You posted 2 days ago but I just received the notification. Strange...

You are right. I need to review this. The "regenerator/runtime" warning is annoying but harmless. I will fix it.

@bjouhier bjouhier added the bug label Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants