Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release process #14548

Open
dahlinPL opened this issue Jan 13, 2025 · 6 comments
Open

Release process #14548

dahlinPL opened this issue Jan 13, 2025 · 6 comments

Comments

@dahlinPL
Copy link
Contributor

Hi!

I have question about possibility to patch not latest ONE release. Let's suppose that this PR will be successfully merged. As currently latest ONE release is 1.29.0 we can expect it will be included in next release, which be I can guess 1.29.1 or 1.30.0. My question is, if this PR could be also included in 1.28.x? Currently it's 1.28.0 but if it's possible to bump it to 1.28.1 with this PR?

@hseok-oh
Copy link
Contributor

hseok-oh commented Jan 14, 2025

As currently latest ONE release is 1.29.0 we can expect it will be included in next release, which be I can guess 1.29.1 or 1.30.0

Current development version is 1.30.0, so commit in master branch will be included in 1.30.0.

My question is, if this PR could be also included in 1.28.x?

If you want to patch to previous release, you should request to maintainers to release new patch version with your requirement. If maintainers allow requirement, we will decide to release new patch version, then release process will be started.

If we need patch to 1.28.x version, we may add patch commit to release/1.28.0 branch or new release/1.28.1 branch (branch out from release/1.28.0) with version update.

@dahlinPL
Copy link
Contributor Author

@hseok-oh Thank you for your answer. I will left this issue opened to allow us request patch of 1.28.x when #14535 will be (eventually) merged.

@tomdol
Copy link
Contributor

tomdol commented Jan 23, 2025

I've created a new release branch for 1.28.1 (using 1.28.0 as a starting point) and backported 3 pull requests to that branch:

#14589
#14590
#14591

@mhs4670go would that be the correct approach to requesting a new release 1.28.1 on top of the existing 1.28.0?

@tomdol
Copy link
Contributor

tomdol commented Jan 24, 2025

@seanshpark could you please have a look and let me know if this is the correct approach to releasing a new version?

@mhs4670go
Copy link
Contributor

@tomdol Hello. I have one question about this. Could you describe why the patch needs to be applied especially to 1.28.0 release? We can just include it to following 1.30.0 release.

@tomdol
Copy link
Contributor

tomdol commented Feb 3, 2025

Hi, the reason is that the NPU Compiler currently uses the 1.28 version of ONE and upgrading to 1.29 or newer is currently blocked because of breaking changes of ONE's API. This is why we'd like to gradually update to 1.28 with necessary fixes and then to something newer when the other issues are figured out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants