Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fileMatch to Traefik v3 #4399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add fileMatch to Traefik v3 #4399

wants to merge 1 commit into from

Conversation

dhenry437
Copy link

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@dhenry437
Copy link
Author

Wasn't aware fileMatch had to be unique.

May not be the best place to ask but, would you have any idea why only Traefik v2 appears in the VS Code YAML extension's JSON schema selector? I thought it may have been the missing fileMatch

@hyperupcall
Copy link
Member

VS Code YAML extension's JSON schema selector? I thought it may have been the missing fileMatch

Not sure - schemas without a fileMatch generally still show up on schema selector menus. I assume that without a fileMatch, the language server assumes that the JSON schema (written as a JSON file) can apply to "any" configuration file type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madskristensen madskristensen Awaiting requested review from madskristensen madskristensen is a code owner

@hyperupcall hyperupcall Awaiting requested review from hyperupcall hyperupcall is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhenry437 @hyperupcall