Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

confusingly worded warning when tspan doesn't include root #161

Closed
ajwheeler opened this issue Sep 26, 2024 · 1 comment
Closed

confusingly worded warning when tspan doesn't include root #161

ajwheeler opened this issue Sep 26, 2024 · 1 comment

Comments

@ajwheeler
Copy link
Contributor

The warning introduced in #158 is great, however the first time I got it I had to do some googling to figure out what it meant. Specifically the wording made me think that opposite signs were required for tspan[1] and tspan[2]. I suggest tweaking it to say that tspan doesn't include a root, or similar.

I can open a PR if you approve of this change.

@ChrisRackauckas
Copy link
Member

Yeah, open a PR. It's easiest to understand whether the new wording is better by seeing the suggestion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants