-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use actual temp files and directories #20
Comments
yes but that's not enough; currently lots of things are broken by fact x.html is deleted right after browser opens it:
proposal 1 (trivial)
proposal 2 (in addition to proposal 1)when user didn't provide that file path:
proposal 3 (if needed, down the line...) tempfile garbage collectionnote: this is a generally useful feature that should be implemented in another package
let tempFile = createManagedTempFile(config = Config(dir = getTempDir(), maxFiles = 100, ...))
`` |
I think proposal 2 for a start would be great. I agree that proposal 3 would be nice, but as you said, it should be a separate library. I'd argue that for most use cases not removing files shouldn't be an issue. The space needed even for > 100 plots is still small. In use cases where this is an issue, I would think the user would not go with a JS based plotting library anyways. |
currently we use /tmp/x.html. should use a real temp file and temporary directory.
The text was updated successfully, but these errors were encountered: