Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A very minor bug when switching between UI color scheme #371

Open
chadchoi opened this issue Dec 19, 2024 · 1 comment
Open

A very minor bug when switching between UI color scheme #371

chadchoi opened this issue Dec 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working ready for release

Comments

@chadchoi
Copy link

chadchoi commented Dec 19, 2024

The menu entry Window -> UI Prefers Color Scheme is not updated for the new UI color scheme. It will remain in the old UI color scheme until you close and open ecode again. For example, if the previous UI color scheme is Dark, if you switch to Light, then both Window and UI Prefers Color Scheme are invisible. I guess it's because the text's color is not updated, but the background color is updated.

@SpartanJ SpartanJ self-assigned this Dec 19, 2024
@SpartanJ SpartanJ added the bug Something isn't working label Dec 19, 2024
SpartanJ added a commit to SpartanJ/eepp that referenced this issue Dec 19, 2024
Slightly increase brighness in inactive tab text color.
@SpartanJ
Copy link
Owner

Oh, yeah, I've seen it for theme change but only fixed it for that, OK, now it's fixed for color scheme also. The fix is just hack, since there's a more complex issue while re-applying a sheet to the UI node tree, issue is that those node element change state during the re-apply of the style and "miss" to apply some of the new changes, so the current "fix" forces to keep the same state during this change. It's good enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for release
Projects
None yet
Development

No branches or pull requests

2 participants