inconsistency OTPInterface param name and HOPT en TOTP param names

[DaanBaars]

Version(s) affected

14.3

Description

When using named arguments window: as from the interface

Interface: \OTPHP\OTPInterface
public function verify(string $otp, null|int $input = null, null|int $window = null): bool;

HOTP
public function verify(string $otp, null|int $counter = null, null|int $window = null): bool

TOTP
public function verify(string $otp, null|int $timestamp = null, null|int $leeway = null): bool

The interface and HOTP both use window the TOTP uses name leeway

This results in error "Unknown named parameter 'Window'"

How to reproduce

$totp = TOTP::create( '{SECRET}', 60, 'sha256', 12 ); $totp->verify('verify_code',window:'window');

Possible Solution

align argument names

Additional Context

No response

[Spomky]

Hello @DaanBaars,

Thank you for your report and for providing the code snippet reproducing the issue.

We’re aware that the HOTP methods (interface and implementation) use the parameter name “window,” whereas the TOTP method uses “leeway.” This difference is intentional, as the TOTP specification refers to the permissible time drift (leeway) rather than a counter-based window.

Please use the following syntax instead:

$totp = TOTP::create( '{SECRET}',  60, 'sha256',  12 );

$totp->verify('verify_code',leeway:'window'); //or
$totp->verify('verify_code',null, 'window');