Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for C# NetCore? #4

Open
dev-bre opened this issue Sep 27, 2020 · 8 comments
Open

Support for C# NetCore? #4

dev-bre opened this issue Sep 27, 2020 · 8 comments

Comments

@dev-bre
Copy link
Contributor

dev-bre commented Sep 27, 2020

Hi,

Can this library be used in a c# NetCore app as well?

@SynOfficial
Copy link
Member

We've kept the code as purely C# so migration to any .NET platform shouldn't be an issue.

@dev-bre
Copy link
Contributor Author

dev-bre commented Sep 29, 2020

are guys open to PRs? for my project i needed a NetCore compatible lib so I already started porting this projects to NetCore:
https://github.com/XandraAI/syn-speech

@SynOfficial
Copy link
Member

SynOfficial commented Sep 29, 2020

We are open to any PR related to Syn.Speech framework if it makes it more helpful to any user. Have you completed the porting or is it still a work in progress?

@dev-bre
Copy link
Contributor Author

dev-bre commented Sep 29, 2020

still on it.i was just checking if you guys were interested.

@SynOfficial
Copy link
Member

A .NET Core version would definitely be useful to some users. We'll have a word with the original author and see if we can have him on board too.

@dev-bre
Copy link
Contributor Author

dev-bre commented Sep 30, 2020

Good.
I already have a NetCore version of the library up and running.

The code is not yet ready for a PR, but it works.

@SynOfficial
Copy link
Member

We usually tend to maintain a single project that targets multiple .NET platforms and adjust certain parts with macros.

Whenever you feel it's fit for a PR you may proceed. We might however optimize the code base to align with certain coding conventions our team follows.

@dev-bre
Copy link
Contributor Author

dev-bre commented Sep 30, 2020

Sounds good multi targeting is what I have in mind myself as well.

NetCore 3.1 and net framework 4.5 sounds good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants