Guitar chord retrieval and display

[Taiko2k]

@legion1978 Guitar chords... interesting. Though I think that might be something better off as its own application maybe? It could connect via MPRIS2 to synchronize with the player, and then it could be used with any music player.

not exactly-- i often jump to the player, grab the guitar and then crank it up.. so it implies the use of a media player.
thing is, [i think all of them] players support lyrics, not chords (meaning retrieve them from some place).

consider this, but scrolling slowly up:

so it doesnt have to be a .lrc file ;) in fact, i very often paste chords and not lyrics in Taoun.
it would be an interesting addition.

Originally posted by @legion1978 in #81 (comment)

[Taiko2k]

I'm not sure if it should have automatic scrolling, or how that would work, but I got a concept here:

[legion1978]

so cool.
and sure it should scroll (on/off state, maybe). so you can keep up with the song till it ends. believe me its very annoying scrolling manually and strumming at the same time :v

[Taiko2k]

How this feature works:

• Theres a new option in the settings, when enabled:
  • Prefers showing lyrics with guitar chords in place of normal lyrics
  • Shows button to search and retrieve guitar chord lyrics of current song
• Theres button to enable auto-scrolling (Auto deactivates if you attempt to scroll manually)

The site I'm using for this is http://www.guitarparty.com/en/. Hopefully they have songs you're interested in there, they seems to have a decently large collection from my quick observation.

[legion1978]

ill test and report back-- man, youre the best.

[Taiko2k]

Just a few things I need to clean up before I do I git push

[legion1978]

:3

[Taiko2k]

OK pushed, hopefully it works. I assume you're familiar with running a git/dev version

[legion1978]

its been a while. lets see how that goes heh

[legion1978]

Running in portable mode
Install directory: /home/downloads/TauonMusicBox-master
Dev mode, ignoring single instancing
Traceback (most recent call last):
File "./tauon.py", line 302, in
from PyLyrics import *
ModuleNotFoundError: No module named 'PyLyrics'

[Taiko2k]

I thought that might happen, if you have the aur version installed, just copy the folder "PyLyrics" in from /opt/tauon-music-box, or copy it out of https://github.com/Taiko2k/TauonMusicBox/releases/download/v4.0.0/Tauon.Music.Box.v4.0.0.Linux.Bass.64bit.zip or you could do sudo pip install pylyrics

[legion1978]

ill get to it

[legion1978]

ok. i had to copy couple of other folders. (then i replaced the executable the other way around) then it broke when didnt find guitar-chords, so i created it.
then it worked! :)
is there a way to scroll already pasted chords? meaning when they dont have the special guitarparty format? though it is better with the colored chords, guitarparty catalogue doesn't seem that extense :v

great work

[Taiko2k]

I could add a function to attempt to parse it from the format you have in that screen shot. Do you know if the chord positions are just a rough estimate... or it is accurate and using relative monospacing to give the positions?

[legion1978]

the difference in formats is that the usual chord found online has the letter on top of the word it should be played (as in the screenshot), whereas this guitarparty format has them before the word in brackets, like this:

[F] [Gm] [Bb] [Gm] [Bb] [F]
[F] [Gm] [Bb] [Gm] [Bb] [F]

I'd [F]sit alone and watch your light
My [Gm]only friend through teenage nights
And [Bb]everything I had to know
I [Gm]heard it on my [Bb]radi[F]o

so yes its accurate.

for some reason, TMB is not honoring the spaces on those letters at the beginning:

[Taiko2k]

It is actually measuring the spaces, just since the font is not monospace, they're much narrower, I can compensate this by replacing multiple spaces with wider spaces:

[Taiko2k]

I pushed an update.

Now, in the right click menu, there's an option 'Paste Chord Lyrics", which will take that 2 line format and save it. Theres also now a Clear Chord Lyrics option too.

So, to copy your existing lyrics, you'll need do a copy then a paste.

Its not perfect reading separated line format, but it seems to work most of the time.

[legion1978]

man, it works and its awesome!
really, thanks for this.

[C0rn3j]

or you could do sudo pip install pylyrics

That makes the package manager sad. You shouldn't run pip with sudo, either run it with --user or in a virtualenv to not mess with your OS packaging.

Looks like you can add Tauon to the list here -

https://en.wikipedia.org/wiki/LRC_(file_format)#Software

[Taiko2k]

You're right. Pacman would get angry with me sometimes. I never realised there was a --user flag or I guess I never thought to use it, but I should.

As for editing Wikipedia, I'm not sure I feel that's something I should do myself, seems like conflict of interest on my part.

[C0rn3j]

Well at least you didn't sudo pip update all packages, that was the only time I was forced to reinstall Arch.

I added Tauon to the Wiki page myself then.

[legion1978]

hello.
did we lose this? :(

[C0rn3j]

Yep - https://github.com/Taiko2k/Tauon/blob/master/CHANGELOG.md#v790

The old guitarparty.com API is completely dead now, someone would need to port things over to the new API - #1342

It was assumed that nobody was even using the chords feature, it's currently kept commented and the module is separated out (and semi-broken) here - https://github.com/Taiko2k/Tauon/blob/9afde0c4a29b9f6742d94b935ec8c28569dd565b/src/tauon/t_modules/guitar_chords.py

It's not impossible to resurrect the chords feature, but someone would have to fix the API integration with guitarparty.com too to make it complete.

EDIT: I fixed up the unused code (still unused) in #1405, so re-enabling it later should be easy.

[legion1978]

gotcha.
though just the hability to paste/display the chords should suffice. because for instance i rarely got any hit from guitarparty anyway.

thanks

[C0rn3j]

@legion1978 you can test the build from #1409 as per https://github.com/Taiko2k/Tauon/wiki/Development-builds

[legion1978]

@legion1978 you can test the build from #1409 as per https://github.com/Taiko2k/Tauon/wiki/Development-builds

yes, it works ;) great