Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Poorly Crafted Table" is used for 2 items #383

Open
Faalagorn opened this issue Nov 7, 2020 · 3 comments
Open

"Poorly Crafted Table" is used for 2 items #383

Faalagorn opened this issue Nov 7, 2020 · 3 comments

Comments

@Faalagorn
Copy link
Contributor

Faalagorn commented Nov 7, 2020 •
edited
Loading

https://github.com/TheIndieStone/ProjectZomboidTranslations/blob/master/EN/Moveables_EN.txt#L519 – this string is used for both small Table and Table with Drawer crafted with Carpentry levels 0-3.
Faalagorn added a commit to Faalagorn/ProjectZomboidTranslations that referenced this issue Nov 7, 2020
@Faalagorn
Unified crafted movable names
0965267 
* Currently used the nomenclature bar counters use (*Poorly Crafted*, *Crafted*, *Quality Crafted*) for Tables, Large Tables, Tables with Drawers and Chairs – this means no *Shoddy*, *Poor Quality*/*Mediocre*/*Medium* and *Exceptional*/*Exceptionally Crafted*/*Quality* on any items though I'm open for discussion for better naming:
* Fixed Crafte**r** Corner Counter → Crafte**d** Corner Counter
* Currently both Table and Table with Drawers crafted with Carpentry 0-3 share *Shoddy Table* string, see TheIndieStone#383
* Doorframes, Doors and Fences currently don't use names at all since they aren't pickable at all even if they use 3 stages of crafting while crates, rain collectors and, bookshelves only have two. Other items currently only have one stage excluding walls which use a different mechanic entirely.
@Faalagorn Faalagorn mentioned this issue Nov 7, 2020
Merged
@Faalagorn Faalagorn changed the title "Shoddy Table" is used for 2 items "Poorly Crafted Table" is used for 2 items Jan 23, 2021
@Faalagorn
Copy link
Contributor Author

Updated the name, as since a38d3eb the name has changed, but the issue is still there, something that probably needs to be fixed in game to give one of these movables an unique name. :)

@Faalagorn
Copy link
Contributor Author

Leaving a related forum thread I made for reference too https://theindiestone.com/forums/index.php?/topic/33703-poorly-crafted-table-name-is-used-for-two-different-furnitures/&tab=comments#comment-306459 but seeing Pandorea's pie under it it's a matter of time until this can be fixed and this issue closed. :)

@Faalagorn
Copy link
Contributor Author

Any chance of addressing it with the upcoming patch @nsKpz? Shouldn't be too hard to do, but requires access to game files :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Faalagorn