Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starter project: Optimize map importer #270

Closed
dabreegster opened this issue Aug 12, 2020 · 4 comments
Closed

Starter project: Optimize map importer #270

dabreegster opened this issue Aug 12, 2020 · 4 comments
Labels
good first issue Good for newcomers

Comments

@dabreegster
Copy link
Collaborator

Importing all of London, https://github.com/dabreegster/abstreet/blob/7a0dbb28b1e711bb9a9f7265ff95e3ee411089df/map_model/src/make/parking_lots.rs#L141 took 40 seconds. It's easy to use timer.parallelize to speed this up. Running the importer on large areas, checking the logs for the slowest steps, and applying simple fixes like parallelize and FindClosest is a great way to learn a bit about the map importing process.

@dabreegster dabreegster added the good first issue Good for newcomers label Aug 12, 2020
@at-tran
Copy link

at-tran commented Dec 19, 2020

Is this issue solved? If not I would like to take a crack at it.

@dabreegster
Copy link
Collaborator Author

@at-tran: I just reimported the largest maps, and the time is now almost totally spent building the contraction hierarchies for pathfinding. All of the other inefficiencies have been fixed, so I'll close out this issue.

If you're interested in data structures, #54 is another optimization task that's a ~gentle introduction to the simulation layer. Or if you're particularly interested in map importing, simulation, graphics, etc, I could point you towards other good starter bugs.

@dabreegster
Copy link
Collaborator Author

#85 may also be of interest if you have knowledge of downsampling timeseries data

@at-tran
Copy link

at-tran commented Dec 19, 2020

Thanks for the suggestions! I'll take a look at those issues and decide what I want to work on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants